Thread (35 messages) 35 messages, 8 authors, 2023-10-17

Re: [PATCH V2 6/7] arm64: dts: qcom: ipq9574: Add support for nsscc node

From: Krzysztof Kozlowski <hidden>
Date: 2023-09-13 08:26:23
Also in: linux-arm-kernel, linux-arm-msm, linux-clk, linux-devicetree, lkml

On 13/09/2023 10:23, Geert Uytterhoeven wrote:
quoted
quoted
+                       clock-names = "nssnoc_nsscc", "nssnoc_snoc", "nssnoc_snoc_1",
+                                     "bias_pll_cc_clk", "bias_pll_nss_noc_clk",
+                                     "bias_pll_ubi_nc_clk", "gpll0_out_aux", "uniphy0_nss_rx_clk",
+                                     "uniphy0_nss_tx_clk", "uniphy1_nss_rx_clk",
+                                     "uniphy1_nss_tx_clk", "uniphy2_nss_rx_clk",
+                                     "uniphy2_nss_tx_clk", "xo_board_clk";
You are using clock indices. Please drop clock-names.
What do you mean by "using clock indices"?
Note that the "clock-names" property is required according to the DT bindings.
Indeed, thanks for pointing this out. Probably bindings should be changed.

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help