Hi Dmitry,

On Fri, Aug 25, 2023 at 1:28 PM Dmitry Baryshkov
[off-list ref] wrote:

On Fri, 25 Aug 2023 at 12:15, Devi Priya [off-list ref] wrote:

quoted

Add a node for the nss clock controller found on ipq9574 based devices.

Signed-off-by: Devi Priya <redacted>
---
 Changes in V2:
        - Dropped the fixed clock node gcc_gpll0_out_aux and added
          support for the same in gcc driver
        - Updated the node name to clock-controller@39b00000
        - Added clock-names to retrieve the nssnoc clocks and add them
          to the list of pm clocks in nss driver

 arch/arm64/boot/dts/qcom/ipq9574.dtsi | 48 +++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index 51aba071c1eb..903311547e96 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi

@@ -722,6 +742,34 @@ frame@b128000 {
                                status = "disabled";
                        };
                };
+
+               nsscc: clock-controller@39b00000 {
+                       compatible = "qcom,ipq9574-nsscc";
+                       reg = <0x39b00000 0x80000>;
+                       clocks = <&gcc GCC_NSSNOC_NSSCC_CLK>,
+                                <&gcc GCC_NSSNOC_SNOC_CLK>,
+                                <&gcc GCC_NSSNOC_SNOC_1_CLK>,
+                                <&bias_pll_cc_clk>,
+                                <&bias_pll_nss_noc_clk>,
+                                <&bias_pll_ubi_nc_clk>,
+                                <&gcc GPLL0_OUT_AUX>,
+                                <0>,
+                                <0>,
+                                <0>,
+                                <0>,
+                                <0>,
+                                <0>,
+                                <&xo_board_clk>;

If you move xo_board closer to the start of the list, it will be
slightly easier to review.

quoted

+                       clock-names = "nssnoc_nsscc", "nssnoc_snoc", "nssnoc_snoc_1",
+                                     "bias_pll_cc_clk", "bias_pll_nss_noc_clk",
+                                     "bias_pll_ubi_nc_clk", "gpll0_out_aux", "uniphy0_nss_rx_clk",
+                                     "uniphy0_nss_tx_clk", "uniphy1_nss_rx_clk",
+                                     "uniphy1_nss_tx_clk", "uniphy2_nss_rx_clk",
+                                     "uniphy2_nss_tx_clk", "xo_board_clk";

You are using clock indices. Please drop clock-names.

What do you mean by "using clock indices"?
Note that the "clock-names" property is required according to the DT bindings.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds