Re: [PATCH v2 2/4] riscv: dts: allwinner: d1: Add CAN controller nodes

Dne sobota, 05. avgust 2023 ob 18:51:53 CEST je John Watts napisal(a):

On Sat, Aug 05, 2023 at 07:40:52PM +0300, Maksim Kiselev wrote:

quoted

Hi John, Jernej
Should we also keep a pinctrl nodes itself in alphabetical order?
I mean placing a CAN nodes before `clk_pg11_pin` node?
Looks like the other nodes sorted in this way...

Good catch. Now that you mention it, the device tree nodes are sorted
by memory order too! These should be after i2c3.

It looks like I might need to do a patch to re-order those too.

It would be better if DT patches are dropped from netdev tree and then post 
new versions.

Best regards,
Jernej

quoted

Cheers,
Maksim

John.