Re: [PATCH v2 2/4] riscv: dts: allwinner: d1: Add CAN controller nodes
From: Maksim Kiselev <hidden>
Date: 2023-08-05 16:41:02
Also in:
linux-arm-kernel, linux-can, linux-devicetree, linux-riscv, linux-sunxi, lkml
Hi John, Jernej On Sat, Jul 22, 2023 at 08:15:51AM +1000, John Watts wrote:
quoted hunk ↗ jump to hunk
...@@ -131,6 +131,18 @@ uart3_pb_pins: uart3-pb-pins {pins = "PB6", "PB7"; function = "uart3"; }; + + /omit-if-no-ref/ + can0_pins: can0-pins { + pins = "PB2", "PB3"; + function = "can0"; + }; + + /omit-if-no-ref/ + can1_pins: can1-pins { + pins = "PB4", "PB5"; + function = "can1"; + }; ...
Should we also keep a pinctrl nodes itself in alphabetical order? I mean placing a CAN nodes before `clk_pg11_pin` node? Looks like the other nodes sorted in this way... Cheers, Maksim