RE: [RFC PATCH v7 2/8] dpll: Add DPLL framework base functions

From: Paolo Abeni <pabeni@redhat.com>
Sent: Monday, May 22, 2023 4:45 PM

On Thu, 2023-04-27 at 17:20 -0700, Vadim Fedorenko wrote:

quoted

From: Vadim Fedorenko <vadim.fedorenko@linux.dev>

DPLL framework is used to represent and configure DPLL devices
in systems. Each device that has DPLL and can configure sources
and outputs can use this framework. Netlink interface is used to
provide configuration data and to receive notification messages
about changes in the configuration or status of DPLL device.
Inputs and outputs of the DPLL device are represented as special
objects which could be dynamically added to and removed from DPLL
device.

Co-developed-by: Milena Olech <redacted>
Signed-off-by: Milena Olech <redacted>
Co-developed-by: Michal Michalik <redacted>
Signed-off-by: Michal Michalik <redacted>
Co-developed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>

As this patch is quite big and tend to accumulate quite a few comments
- both hard to track and to address - I'm wondering if splitting it in
a few separated patches would could help?

e.g.

- 1 patch for dpll device struct && APIs definition
- 1 patch for pin related APIs
- 1 patch for netlink notification.

(to be considered only if the effort for the above split is not
overwhelming)

Possibly the same could apply to patch 5/8.

Cheers,

Paolo

Sure, I split this patch for v8 (only separating the outcome object
files and header for easier review), but didn't managed to split the
ice patch yet, hopefully will manage this for next submission.

Thank you!
Arkadiusz