Re: [RFC PATCH v7 5/8] ice: implement dpll interface to control cgu
flat view
From: Jiri Pirko <jiri@resnulli.us>
Date: 2023-05-15 17:14:34
Also in:
linux-arm-kernel, linux-clk
Fri, Apr 28, 2023 at 02:20:06AM CEST, vadfed@meta.com wrote: [...]
quoted hunk ↗ jump to hunk
+static const enum dpll_lock_status +ice_dpll_status[__DPLL_LOCK_STATUS_MAX] = { + [ICE_CGU_STATE_INVALID] = DPLL_LOCK_STATUS_UNSPEC, + [ICE_CGU_STATE_FREERUN] = DPLL_LOCK_STATUS_UNLOCKED, + [ICE_CGU_STATE_LOCKED] = DPLL_LOCK_STATUS_CALIBRATING,
This is a bit confusing to me. You are locked, yet you report calibrating? Wouldn't it be better to have: DPLL_LOCK_STATUS_LOCKED DPLL_LOCK_STATUS_LOCKED_HO_ACQ ?
quoted hunk ↗ jump to hunk
+ [ICE_CGU_STATE_LOCKED_HO_ACQ] = DPLL_LOCK_STATUS_LOCKED, + [ICE_CGU_STATE_HOLDOVER] = DPLL_LOCK_STATUS_HOLDOVER, +};
[...]