RE: [RFC PATCH v7 1/8] dpll: spec: Add Netlink spec in YAML

From: Jakub Kicinski <kuba@kernel.org>
Sent: Thursday, May 11, 2023 5:27 PM

On Thu, 11 May 2023 07:38:04 +0000 Kubalewski, Arkadiusz wrote:

quoted

quoted

quoted

+  -
+    type: enum
+    name: event
+    doc: events of dpll generic netlink family
+    entries:
+      -
+        name: unspec
+        doc: invalid event type
+      -
+        name: device-create
+        doc: dpll device created
+      -
+        name: device-delete
+        doc: dpll device deleted
+      -
+        name: device-change

Please have a separate create/delete/change values for pins.

Makes sense, but details, pin creation doesn't occur from uAPI perspective,
as the pins itself are not visible to the user. They are visible after they
are registered with a device, thus we would have to do something like:
- pin-register
- pin-unregister
- pin-change

Does it make sense?

I missed this, notifications should be declared under operations.

Please look at netdev.yaml for an example.

I thought about implementing this model where events are separate
explicitly but I think it's an unnecessary complication.

Ok, will do.

Thank you!
Arkadiusz