Thread (73 messages) 73 messages, 8 authors, 2023-07-17

RE: [RFC PATCH v8 04/10] dpll: netlink: Add DPLL framework base functions

From: "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>
Date: 2023-06-23 00:56:59
Also in: intel-wired-lan, linux-clk, linux-doc, linux-rdma, lkml

From: Petr Oros <redacted>
Sent: Wednesday, June 21, 2023 1:19 PM
[...]
quoted
+
+static int
+dpll_set_from_nlattr(struct dpll_device *dpll, struct genl_info
*info)
+{
+       const struct dpll_device_ops *ops = dpll_device_ops(dpll);
+       struct nlattr *tb[DPLL_A_MAX + 1];
+       int ret = 0;
+
+       nla_parse(tb, DPLL_A_MAX, genlmsg_data(info->genlhdr),
+                 genlmsg_len(info->genlhdr), NULL, info->extack);
+       if (tb[DPLL_A_MODE]) {
Hi,

Here should be something like:
              if (!ops->mode_set)
                      return -EOPNOTSUPP;

Regards,
Petr
Sure, fixed.

Thank you!
Arkadiusz

[...]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help