Re: [PATCH v4 5/6] connector/cn_proc: Performance improvements
From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-06-01 16:48:34
Also in:
lkml
From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-06-01 16:48:34
Also in:
lkml
On Thu, 1 Jun 2023 16:38:04 +0000 Anjali Kulkarni wrote:
quoted
The #define FILTER and ifdefs around it need to go, this much I can tell you without understanding what it does :S We have the git history we don't need to keep dead code around.The FILTER option is for backwards compatibility for those who may be using the proc connector today - so they do not need to immediately switch to using the new method - the example just shows the old method which does not break or need changes - do you still want me to remove the FILTER?
Is it possible to recode the sample so the format can be decided based on cmd line argument? To be honest samples are kinda dead, it'd be best if the code was rewritten to act as a selftest.