On Jun 1, 2023, at 9:25 AM, Jakub Kicinski [off-list ref] wrote:

On Fri, 31 Mar 2023 16:55:27 -0700 Anjali Kulkarni wrote:

quoted

+#define FILTER
+
+#ifdef FILTER
+#define NL_MESSAGE_SIZE (sizeof(struct nlmsghdr) + sizeof(struct cn_msg) + \
+			 sizeof(struct proc_input))
+#else
#define NL_MESSAGE_SIZE (sizeof(struct nlmsghdr) + sizeof(struct cn_msg) + \
			 sizeof(int))
+#endif

The #define FILTER and ifdefs around it need to go, this much I can
tell you without understanding what it does :S We have the git history
we don't need to keep dead code around.

The FILTER option is for backwards compatibility for those who may be using the proc connector today - so they do not need to immediately switch to using the new method - the example just shows the old method which does not break or need changes - do you still want me to remove the FILTER? 

Anjali