Re: [RFC/RFTv3 10/24] net: lan743x: Fixup EEE
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2023-05-30 18:03:13
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2023-05-30 18:03:13
On 3/30/23 17:55, Andrew Lunn wrote:
The enabling/disabling of EEE in the MAC should happen as a result of auto negotiation. So move the enable/disable into lan743x_phy_link_status_change() which gets called by phylib when there is a change in link status. lan743x_ethtool_set_eee() now just programs the hardware with the LTI timer value, and passed everything else to phylib, so it can correctly setup the PHY. lan743x_ethtool_get_eee() relies on phylib doing most of the work, the MAC driver just adds the LTI timer value. Signed-off-by: Andrew Lunn <andrew@lunn.ch>
LGTM: Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> -- Florian