Re: [RFC PATCH 23/28] algif: Remove hash_sendpage*()

From
David Howells <dhowells@redhat.com>
Date
2023-03-24 16:48:59
Also in
linux-crypto, linux-fsdevel, linux-mm, lkml
Reply to
Herbert Xu, 2023-03-17
Herbert Xu [off-list ref] wrote:
David Howells [off-list ref] wrote:
quoted
Remove hash_sendpage*() and use hash_sendmsg() as the latter seems to just
use the source pages directly anyway.
...
quoted
-       if (!(flags & MSG_MORE)) {
-               if (ctx->more)
-                       err = crypto_ahash_finup(&ctx->req);
-               else
-                       err = crypto_ahash_digest(&ctx->req);
You've just removed the optimised path from user-space to
finup/digest.  You need to add them back to sendmsg if you
want to eliminate sendpage.
I must be missing something, I think.  What's particularly optimal about the
code in hash_sendpage() but not hash_sendmsg()?  Is it that the former uses
finup/digest, but the latter ony does update+final?

Also, looking at:

	if (!ctx->more) {
		if ((msg->msg_flags & MSG_MORE))
			hash_free_result(sk, ctx);

how is ctx->more meant to be interpreted?  I'm guessing it means that we're
continuing to the previous op.  But we do we need to free any old result if
MSG_MORE is set, but not if it isn't?

David
Thread (54 messages) 54 messages, 7 authors, last reply 2023-03-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help