Re: [RFC PATCH 23/28] algif: Remove hash_sendpage*()

From
Herbert Xu <herbert@gondor.apana.org.au>
Date
2023-03-17 02:41:59
Also in
linux-crypto, linux-fsdevel, lkml
Reply to
David Howells, 2023-03-16
David Howells [off-list ref] wrote:
Remove hash_sendpage*() and use hash_sendmsg() as the latter seems to just
use the source pages directly anyway.
...
-       if (!(flags & MSG_MORE)) {
-               if (ctx->more)
-                       err = crypto_ahash_finup(&ctx->req);
-               else
-                       err = crypto_ahash_digest(&ctx->req);
You've just removed the optimised path from user-space to
finup/digest.  You need to add them back to sendmsg if you
want to eliminate sendpage.

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Thread (54 messages) 54 messages, 7 authors, last reply 2023-03-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help