Re: [RFC PATCH 27/28] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage

[RFC PATCH 00/28] splice, net: Replace sendpage with sendmsg(MSG_SPLICE_PAGES) · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 01/28] net: Declare MSG_SPLICE_PAGES internal sendmsg() flag · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 02/28] Add a special allocator for staging netfs protocol to MSG_SPLICE_PAGES · David Howells <dhowells@redhat.com> · 2023-03-16
Re: [RFC PATCH 02/28] Add a special allocator for staging netfs protocol to MSG_SPLICE_PAGES · Matthew Wilcox <willy@infradead.org> · 2023-03-16
Re: [RFC PATCH 02/28] Add a special allocator for staging netfs protocol to MSG_SPLICE_PAGES · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 03/28] tcp: Support MSG_SPLICE_PAGES · David Howells <dhowells@redhat.com> · 2023-03-16
RE: [RFC PATCH 03/28] tcp: Support MSG_SPLICE_PAGES · Willem de Bruijn <willemdebruijn.kernel@gmail.com> · 2023-03-16
Re: [RFC PATCH 03/28] tcp: Support MSG_SPLICE_PAGES · David Howells <dhowells@redhat.com> · 2023-03-16
Re: [RFC PATCH 03/28] tcp: Support MSG_SPLICE_PAGES · Willem de Bruijn <willemdebruijn.kernel@gmail.com> · 2023-03-16
Re: [RFC PATCH 03/28] tcp: Support MSG_SPLICE_PAGES · David Howells <dhowells@redhat.com> · 2023-03-21
Re: [RFC PATCH 03/28] tcp: Support MSG_SPLICE_PAGES · Willem de Bruijn <willemdebruijn.kernel@gmail.com> · 2023-03-21
[RFC PATCH 0/3] net: Drop size arg from ->sendmsg() and pass msghdr into __ip{,6}_append_data() · David Howells <dhowells@redhat.com> · 2023-03-22
[RFC PATCH 2/3] ip: Make __ip{,6}_append_data() and co. take a msghdr* · David Howells <dhowells@redhat.com> · 2023-03-22
[RFC PATCH 3/3] net: Declare MSG_SPLICE_PAGES internal sendmsg() flag · David Howells <dhowells@redhat.com> · 2023-03-22
[RFC PATCH 1/3] net: Drop the size argument from ->sendmsg() · David Howells <dhowells@redhat.com> · 2023-03-22
RE: [RFC PATCH 0/3] net: Drop size arg from ->sendmsg() and pass msghdr into __ip{,6}_append_data() · Willem de Bruijn <willemdebruijn.kernel@gmail.com> · 2023-03-23
[RFC PATCH 05/28] tcp_bpf: Inline do_tcp_sendpages as it's now a wrapper around tcp_sendmsg · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 04/28] tcp: Convert do_tcp_sendpages() to use MSG_SPLICE_PAGES · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 12/28] af_unix: Support MSG_SPLICE_PAGES · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 06/28] espintcp: Inline do_tcp_sendpages() · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 07/28] tls: Inline do_tcp_sendpages() · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 09/28] tcp: Fold do_tcp_sendpages() into tcp_sendpage_locked() · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 11/28] udp: Convert udp_sendpage() to use MSG_SPLICE_PAGES · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 10/28] ip, udp: Support MSG_SPLICE_PAGES · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 08/28] siw: Inline do_tcp_sendpages() · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 14/28] crypto: af_alg: Support MSG_SPLICE_PAGES · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 13/28] crypto: af_alg: Indent the loop in af_alg_sendmsg() · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 15/28] crypto: af_alg: Convert af_alg_sendpage() to use MSG_SPLICE_PAGES · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 16/28] splice, net: Use sendmsg(MSG_SPLICE_PAGES) rather than ->sendpage() · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 18/28] siw: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage to transmit · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 17/28] Remove file->f_op->sendpage · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 22/28] net: Use sendmsg(MSG_SPLICE_PAGES) not sendpage in skb_send_sock() · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 19/28] ceph: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 21/28] tcp_bpf: Make tcp_bpf_sendpage() go through tcp_bpf_sendmsg(MSG_SPLICE_PAGES) · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 20/28] iscsi: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 23/28] algif: Remove hash_sendpage*() · David Howells <dhowells@redhat.com> · 2023-03-16
Re: [RFC PATCH 23/28] algif: Remove hash_sendpage*() · Herbert Xu <herbert@gondor.apana.org.au> · 2023-03-17
Re: [RFC PATCH 23/28] algif: Remove hash_sendpage*() · David Howells <dhowells@redhat.com> · 2023-03-24
Re: [RFC PATCH 23/28] algif: Remove hash_sendpage*() · Herbert Xu <herbert@gondor.apana.org.au> · 2023-03-25
Re: [RFC PATCH 23/28] algif: Remove hash_sendpage*() · David Howells <dhowells@redhat.com> · 2023-03-25
Re: [RFC PATCH 23/28] algif: Remove hash_sendpage*() · Herbert Xu <herbert@gondor.apana.org.au> · 2023-03-25
[RFC PATCH 24/28] ceph: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage() · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 25/28] rds: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 27/28] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage · David Howells <dhowells@redhat.com> · 2023-03-16
Re: [RFC PATCH 27/28] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage · Trond Myklebust <hidden> · 2023-03-16
Re: [RFC PATCH 27/28] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage · David Howells <dhowells@redhat.com> · 2023-03-16
Re: [RFC PATCH 27/28] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage · Chuck Lever III <hidden> · 2023-03-16
Re: [RFC PATCH 27/28] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage · David Howells <dhowells@redhat.com> · 2023-03-16
Re: [RFC PATCH 27/28] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage · Chuck Lever III <hidden> · 2023-03-16
Re: [RFC PATCH 27/28] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage · David Howells <dhowells@redhat.com> · 2023-03-16
Re: [RFC PATCH 27/28] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage · Chuck Lever III <hidden> · 2023-03-17
[RFC PATCH 26/28] dlm: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage · David Howells <dhowells@redhat.com> · 2023-03-16
[RFC PATCH 28/28] sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES) · David Howells <dhowells@redhat.com> · 2023-03-16
Re: [RFC PATCH 28/28] sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES) · Marc Kleine-Budde <mkl@pengutronix.de> · 2023-03-16

From: David Howells <dhowells@redhat.com>
Date: 2023-03-16 16:25:45
Also in: linux-fsdevel, linux-mm, linux-nfs, lkml

Trond Myklebust [off-list ref] wrote:

quoted

+ buf->bvec += 2;
+ buf->bvec[-2].bv_page = NULL;
+ buf->bvec[-1].bv_page = NULL;

NACK.

Can you elaborate?

Is it that you dislike allocating extra slots for protocol bits?  Or just that
the bvec[] is offset by 2?  Or some other reason?

David

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help