Re: [PATCH 05/28] bnxt: Drop redundant pci_enable_pcie_error_reporting()
From: Michael Chan <michael.chan@broadcom.com>
Date: 2023-03-08 00:23:48
Also in:
lkml
On Tue, Mar 7, 2023 at 10:20 AM Bjorn Helgaas [off-list ref] wrote:
From: Bjorn Helgaas <bhelgaas@google.com>
pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration.
Remove the redundant pci_enable_pcie_error_reporting() call from the
driver. Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.
Note that this only controls ERR_* Messages from the device. An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Michael Chan <michael.chan@broadcom.com>Reviewed-by: Michael Chan <michael.chan@broadcom.com> Thanks.
Attachments
- smime.p7s [application/pkcs7-signature] 4209 bytes