Re: [PATCH v7 1/2] net/handshake: Create a NETLINK service for handling handshake requests
From: Paolo Abeni <pabeni@redhat.com>
Date: 2023-03-22 09:08:09
On Sat, 2023-03-18 at 12:18 -0400, Chuck Lever wrote:
static bool __add_pending_locked(struct handshake_net *hn,
+ struct handshake_req *req)
+{
+ if (!list_empty(&req->hr_list))
+ return false;I think the above condition should be matched only an bugs/API misuse, am I correct? what about adding a WARN_ON_ONCE()? Thanks! Paolo