On 11/4/2022 7:10 PM, Jakub Kicinski wrote:

On Fri,  4 Nov 2022 15:30:54 +0100 Michal Wilczynski wrote:

quoted

+		if (attrs[DEVLINK_ATTR_RATE_TX_PRIORITY] && !ops->rate_leaf_tx_priority_set) {
+			NL_SET_ERR_MSG_MOD(info->extack,
+					   "TX priority set isn't supported for the leafs");

Please point to the attribute - NL_SET_ERR_MSG_ATTR().

I'm not entirely sure why we keep slapping the _MOD() on the extacks,
but if you care to keep that you may need to add the _MOD flavor of
the above.

_MOD is useful in driver code because it will indicate that it came from 
a given driver module, but I don't think its useful in the core devlink 
or other networking files.