Thread (28 messages) 28 messages, 4 authors, 2022-11-08

Re: [PATCH net-next v9 1/9] devlink: Introduce new attribute 'tx_priority' to devlink-rate

From: Wilczynski, Michal <hidden>
Date: 2022-11-07 18:17:44


On 11/5/2022 3:10 AM, Jakub Kicinski wrote:
On Fri,  4 Nov 2022 15:30:54 +0100 Michal Wilczynski wrote:
quoted
+		if (attrs[DEVLINK_ATTR_RATE_TX_PRIORITY] && !ops->rate_leaf_tx_priority_set) {
+			NL_SET_ERR_MSG_MOD(info->extack,
+					   "TX priority set isn't supported for the leafs");
Please point to the attribute - NL_SET_ERR_MSG_ATTR().

I'm not entirely sure why we keep slapping the _MOD() on the extacks,
but if you care to keep that you may need to add the _MOD flavor of
the above.
Changed to this macro in v10, thanks

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help