On 11/5/2022 3:07 AM, Jakub Kicinski wrote:

On Fri,  4 Nov 2022 15:30:54 +0100 Michal Wilczynski wrote:

quoted

+	DEVLINK_ATTR_RATE_TX_PRIORITY,		/* u16 */

All netlink attributes are padded out to 4 bytes, please make this u32,
you shouldn't use smaller values at netlink level unless it's carrying
protocol fields with fixed width.

Sure changed that in v10

quoted

+	int (*rate_leaf_tx_priority_set)(struct devlink_rate *devlink_rate, void *priv,
+					 u64 tx_priority, struct netlink_ext_ack *extack);

And why make the driver API u64?

Thanks for pointing this out, this is an oversight, fixed this in v10.