Hi Andrew,

Thank you for your review!

From: Andrew Lunn, Sent: Tuesday, September 13, 2022 7:32 AM

quoted

+  '#address-cells':
+    description: Number of address cells for the MDIO bus.
+    const: 1

Please could you explain this a bit more.

I realized that the property is completely wrong.
This #address-cells here (out of "port") is not needed.
So, I'll drop it.
Instead of that, I'll add a description of "#address-cell"
in the port as " Port number of ETHA (TSNA)".

quoted

+
+  '#size-cells':
+    description: Number of size cells on the MDIO bus.
+    const: 0

Also I'll drop this.

quoted

+  ports:
+    type: object

I think ethernet-ports is the preferred name.

OK. I'll rename it.

quoted

+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - interrupts
+  - interrupt-names
+  - clocks
+  - clock-names
+  - resets
+  - power-domains
+  - '#address-cells'
+  - '#size-cells'

So ports are not required? You can have a 0 port switch?

Thank you for pointed it out. I'll add "ethernet-ports" and
drop '#address-cells' and '#size-cells'.

Best regards,
Yoshihiro Shimoda

   Andrew