RE: [PATCH 3/5] net: ethernet: renesas: Add Ethernet Switch driver

Hi kernel test robot,

From: kernel test robot, Sent: Saturday, September 10, 2022 2:26 AM

Hi Yoshihiro,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20220909]
[also build test WARNING on v6.0-rc4]
[cannot apply to geert-renesas-devel/next net-next/master net/master linus/master v6.0-rc4 v6.0-rc3 v6.0-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in

<snip>

        git checkout 9c5c4dd0ca6beb269dd0a6ef12c386198e193c68
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash
M=drivers/net/ethernet/renesas

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <redacted>

All warnings (new ones prefixed by >>):

quoted

quoted

drivers/net/ethernet/renesas/rswitch_serdes.c:16:6: warning: no previous prototype for 'rswitch_serdes_write32'

[-Wmissing-prototypes]
      16 | void rswitch_serdes_write32(void __iomem *addr, u32 offs,  u32 bank, u32 data)
         |      ^~~~~~~~~~~~~~~~~~~~~~

quoted

quoted

drivers/net/ethernet/renesas/rswitch_serdes.c:22:5: warning: no previous prototype for 'rswitch_serdes_read32'

[-Wmissing-prototypes]
      22 | u32 rswitch_serdes_read32(void __iomem *addr, u32 offs,  u32 bank)
         |     ^~~~~~~~~~~~~~~~~~~~~

I'll fix this issue on v2.
- Add "static" to rswitch_serdes_write32().
- Remove rswitch_serdes_read32() because no one calls it.

Best regards,
Yoshihiro Shimoda