-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Tuesday, August 23, 2022 3:14 PM
To: Keller, Jacob E <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org; Michael Chan <michael.chan@broadcom.com>; Eric
Dumazet [off-list ref]; Paolo Abeni [off-list ref]; Derek
Chickles [off-list ref]; Satanand Burla [off-list ref]; Felix
Manlunas [off-list ref]; Raju Rangoju [off-list ref];
Dimitris Michailidis [off-list ref]; Yisen Zhuang
[off-list ref]; Salil Mehta [off-list ref];
Brandeburg, Jesse [off-list ref]; Nguyen, Anthony L
[off-list ref]; Sunil Goutham [off-list ref];
Geetha sowjanya [off-list ref]; Subbaraya Sundeep
[off-list ref]; hariprasad [off-list ref]; Taras Chornyi
[off-list ref]; Saeed Mahameed [off-list ref]; Leon
Romanovsky [off-list ref]; Simon Horman
[off-list ref]; Shannon Nelson [off-list ref]; Ariel
Elior [off-list ref]; Manish Chopra [off-list ref]; Edward
Cree [off-list ref]; Martin Habets [off-list ref]; Fei
Qin [off-list ref]; Louis Peens [off-list ref]; Yu Xiao
[off-list ref]; Uwe Kleine-König [off-list ref];
Yufeng Mo [off-list ref]; Sixiang Chen
[off-list ref]; Yinjun Zhang [off-list ref]; Hao
Chen [off-list ref]; Guangbin Huang
[off-list ref]; Sean Anderson [off-list ref];
Erik Ekman [off-list ref]; Ido Schimmel [off-list ref]; Jie Wang
[off-list ref]; Moshe Tal [off-list ref]; Tonghao Zhang
[off-list ref]; Marco Bonelli [off-list ref]; Gustavo A.
R. Silva [off-list ref]
Subject: Re: [PATCH net-next 1/2] ethtool: pass netlink extended ACK to
.set_fecparam

On Tue, 23 Aug 2022 08:04:37 -0700 Jacob Keller wrote:

quoted

Add the netlink extended ACK structure pointer to the interface for
.set_fecparam. This allows reporting errors to the user appropriately when
using the netlink ethtool interface.

Could you wrap it into a structure perhaps?

Would be good if we didn't have to modify the signature of the callback
next time we need to extend it (especially since struct ethtool_fecparam
is ioctl uABI so we can't really add fields there).

Yea that makes sense.

Thanks,
Jake