Re: [PATCH net-next 1/2] ethtool: pass netlink extended ACK to .set_fecparam
From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-08-23 22:16:27
From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-08-23 22:16:27
On Tue, 23 Aug 2022 08:04:37 -0700 Jacob Keller wrote:
Add the netlink extended ACK structure pointer to the interface for .set_fecparam. This allows reporting errors to the user appropriately when using the netlink ethtool interface.
Could you wrap it into a structure perhaps? Would be good if we didn't have to modify the signature of the callback next time we need to extend it (especially since struct ethtool_fecparam is ioctl uABI so we can't really add fields there).