RE: [net-next PATCH 1/2] devlink: add dry run attribute to flash update
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
Date: 2022-08-05 19:50:54
-----Original Message----- From: Jakub Kicinski <kuba@kernel.org> Sent: Friday, August 05, 2022 11:51 AM To: Keller, Jacob E <jacob.e.keller@intel.com> Cc: Jiri Pirko <jiri@resnulli.us>; netdev@vger.kernel.org Subject: Re: [net-next PATCH 1/2] devlink: add dry run attribute to flash update On Fri, 5 Aug 2022 16:32:30 +0000 Keller, Jacob E wrote:quoted
quoted
Hm, yes. Don't invest too much effort into rendering per-cmd policies right now, tho. I've started working on putting the parsing policies in YAML last Friday. This way we can auto-gen the policy for the kernel and user space can auto-gen the parser/nl TLV writer. Long story short we can kill two birds with one stone if you hold off until I have the format ironed out. For now maybe just fork the policies into two - with and without dry run attr. We'll improve the granularity later when doing the YAML conversion.Any update on this? FWIW I started looking at iproute2 code to dump policy and check whether a specific attribute is accepted by the kernel.Yes and no, I coded a little bit of it up, coincidentally I have a YAML policy for genetlink policy querying if that's helpful: https://git.kernel.org/pub/scm/linux/kernel/git/kuba/linux.git/tree/tools/net/ynl /samples/nlctrl.c?h=gnl-gen-dpll
I'll take a look at this.
I'll try to wrap up the YAML format by today / tomorrow and send an early RFC, but the codegen part (and everything else really) still requires much work.
I'd like to see it and provide some early review.
Probably another month until I can post the first non-RFC with error checking, kernel policy generation, uAPI generation etc.
Ya, I figured this would take quite a lot of effort to get to completion.