-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Thursday, July 21, 2022 9:48 AM
To: Keller, Jacob E <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org
Subject: Re: [net-next PATCH 1/2] devlink: add dry run attribute to flash update

On Wed, 20 Jul 2022 11:34:32 -0700 Jacob Keller wrote:

quoted

+	nla_dry_run = info->attrs[DEVLINK_ATTR_DRY_RUN];
+	if (nla_dry_run) {
+		if (!(supported_params &

DEVLINK_SUPPORT_FLASH_UPDATE_DRY_RUN)) {

quoted

+			NL_SET_ERR_MSG_ATTR(info->extack, nla_dry_run,
+					    "flash update is supported, but dry run

is not supported for this device");

quoted

+			release_firmware(params.fw);
+			return -EOPNOTSUPP;
+		}
+		params.dry_run = true;
+	}

Looks over-indented. You can do this, right?

	params.dry_run = nla_get_flag(info->attrs[DEVLINK_ATTR_DRY_RUN]);
	if (params.dry_run &&
	    !(supported_params &
DEVLINK_SUPPORT_FLASH_UPDATE_DRY_RUN)) {
		/* error handling */
	}

Yea that makes more sense.

Thanks,
Jake