RE: [net-next PATCH 1/2] devlink: add dry run attribute to flash update
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
Date: 2022-07-26 18:50:01
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
Date: 2022-07-26 18:50:01
-----Original Message----- From: Jakub Kicinski <kuba@kernel.org> Sent: Tuesday, July 26, 2022 11:49 AM To: Keller, Jacob E <jacob.e.keller@intel.com> Cc: Jiri Pirko <jiri@resnulli.us>; netdev@vger.kernel.org Subject: Re: [net-next PATCH 1/2] devlink: add dry run attribute to flash update On Tue, 26 Jul 2022 17:23:53 +0000 Keller, Jacob E wrote:quoted
quoted
For now maybe just fork the policies into two - with and without dry run attr. We'll improve the granularity later when doing the YAML conversion.Not quite sure I follow this. I guess just add a separate policy array with dry_run and then make that the policy for the flash update command? I don't think flash update is strict yet, and I'm not sure what the impact of changing it to strict is in terms of backwards compatibility with the interface.Strictness is a separate issue, the policy split addresses just the support discoverability question.
Right, ok.