Thread (40 messages) 40 messages, 6 authors, 2022-07-19

Re: [RFC PATCH net-next 4/9] net: pcs: lynx: Convert to an mdio driver

From: Vladimir Oltean <olteanv@gmail.com>
Date: 2022-07-19 16:20:51
Also in: lkml

On Tue, Jul 19, 2022 at 12:16:17PM -0400, Sean Anderson wrote:
quoted
Curiously enough, mdio_device_create() only calls device_initialize().
It's mdio_device_register() that calls device_add(). So after this
patch, we cannot call lynx_pcs_create() without calling
mdio_device_register().
OK, so presumably we need to call mdio_device_register after mdio_device_create.
I suppose I should have caught this because patch 5 does exactly this.
And that's only to not crash during boot, mind you. Networking is broken
at this stage. I'll proceed to patch 5 to see what happens next.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help