Re: [RFC PATCH net-next 2/9] dt-bindings: net: Expand pcs-handle to an array
From: Krzysztof Kozlowski <hidden>
Date: 2022-07-12 08:51:47
Also in:
linux-devicetree, lkml
On 11/07/2022 18:05, Sean Anderson wrote:
quoted hunk ↗ jump to hunk
This allows multiple phandles to be specified for pcs-handle, such as when multiple PCSs are present for a single MAC. To differentiate between them, also add a pcs-names property. Signed-off-by: Sean Anderson <redacted> --- .../devicetree/bindings/net/ethernet-controller.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml index 4f15463611f8..c033e536f869 100644 --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml@@ -107,11 +107,16 @@ properties: $ref: "#/properties/phy-connection-type" pcs-handle: - $ref: /schemas/types.yaml#/definitions/phandle + $ref: /schemas/types.yaml#/definitions/phandle-array description: Specifies a reference to a node representing a PCS PHY device on a MDIO bus to link with an external PHY (phy-handle) if exists.
You need to update all existing bindings and add maxItems:1.
+ pcs-names:
To be consistent with other properties this should be "pcs-handle-names" and the other "pcs-handles"... and then actually drop the "handle".
+ $ref: /schemas/types.yaml#/definitions/string-array + description: + The name of each PCS in pcs-handle.
You also need: dependencies: pcs-names: [ pcs-handle ]
+
phy-handle:
$ref: /schemas/types.yaml#/definitions/phandle
description:Best regards, Krzysztof