On 6/21/22 04:02, Andy Shevchenko wrote:

On Tue, Jun 21, 2022 at 11:27:43AM +0200, Marcin Wojtas wrote:

quoted

pon., 20 cze 2022 o 19:41 Andy Shevchenko
[off-list ref] napisał(a):

quoted

On Mon, Jun 20, 2022 at 05:02:16PM +0200, Marcin Wojtas wrote:

...

quoted

quoted

quoted

       struct device_node      *dn;

What prevents us from removing this?

I left it to satisfy possible issues with backward compatibility - I
migrated mv88e6xxx, other DSA drivers still rely on of_* and may use
this field.

If it is so, it's a way to get into troubles of desynchronized dn and fwnode.

Agreed, we can take it in baby steps if you prefer, but ultimately we 
should move to using a fwnode reference rather than a device_node 
reference and if there are drivers needing the device_node we can always 
extract it from the fwnode.
-- 
Florian