Thread (84 messages) 84 messages, 9 authors, 2022-06-25

Re: [net-next: PATCH 01/12] net: phy: fixed_phy: switch to fwnode_ API

From: Marcin Wojtas <hidden>
Date: 2022-06-21 09:56:24
Also in: linux-acpi, lkml

pon., 20 cze 2022 o 19:59 Andrew Lunn [off-list ref] napisał(a):
On Mon, Jun 20, 2022 at 05:02:14PM +0200, Marcin Wojtas wrote:
quoted
This patch allows to use fixed_phy driver and its helper
functions without Device Tree dependency, by swtiching from
of_ to fwnode_ API.
Do you actually need this? phylink does not use this code, it has its
own fixed link implementation. And that implementation is not limited
to 1G.
Yes, phylink has its own fixed-link handling, however the
net/dsa/port.c relies on fixed_phy helpers these are not 1:1
equivalents. I assumed this migration (fixed_phy -> phylink) is not
straightforward and IMO should be handled separately. Do you recall
justification for not using phylink in this part of net/dsa/*?

Thanks,
Marcin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help