On Mon, Jun 20, 2022 at 08:43:05PM +0300, Andy Shevchenko wrote:
On Mon, Jun 20, 2022 at 05:02:17PM +0200, Marcin Wojtas wrote:
quoted
As a preparation to switch the DSA subsystem from using
of_find_net_device_by_node() to its more generic fwnode_
equivalent, the port's device structure should be updated
with its fwnode pointer, similarly to of_node - see analogous
commit c4053ef32208 ("net: mvpp2: initialize port of_node pointer").
This patch is required to prevent a regression before updating
the DSA API on boards that connect the mvpp2 port to switch,
such as Clearfog GT-8K or CN913x CEx7 Evaluation Board.
...
quoted
dev->dev.of_node = port_node;
+ dev->dev.fwnode = port_fwnode;
device_set_node() ?
Ah, important remark to all device_set_node() comments. It assumes that you
replace _both_ assignments with _single_ call.
--
With Best Regards,
Andy Shevchenko