Thread (16 messages) 16 messages, 5 authors, 2022-05-05

Re: [RFC v2 4/4] arm64: dts: rockchip: Add mt7531 dsa node to BPI-R2-Pro board

From: Krzysztof Kozlowski <hidden>
Date: 2022-05-05 09:22:42
Also in: linux-arm-kernel, linux-devicetree, linux-mediatek, linux-rockchip, lkml

On 05/05/2022 11:06, Frank Wunderlich wrote:
quoted
You can make it "(ethernet-)?ports" as well. My comment was purely to
make it simpler, for bindings (goes into properties, not
patternProperties) and for us. If you prefer to keep it like DSA core,
also fine.
Ok, i'm also thinking, the dsa-definition will be the right way (pattern-properties with optional "ethernet-") in binding.

Should i use "ethernet-ports" instead of "ports" here? Current dts with mt7530/mt7531 switches using "ports" so i would use it here too. If dsa prefer ethernet-ports now it should be changed in other files too.
I think bindings allow both, so choose something consistent with
existing DTS sources.

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help