Thread (31 messages) 31 messages, 13 authors, 2022-04-08

Re: [PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2022-03-19 22:37:34
Also in: lkml, netfilter-devel

[ trimmed off Cc list ]

On Wed, Mar 16, 2022 at 12:20:05PM -0700, Randy Dunlap wrote:
Eliminate anonymous module_init() and module_exit(), which can lead to
confusion or ambiguity when reading System.map, crashes/oops/bugs,
or an initcall_debug log.

Give each of these init and exit functions unique driver-specific
names to eliminate the anonymous names.

Example 1: (System.map)
 ffffffff832fc78c t init
 ffffffff832fc79e t init
 ffffffff832fc8f8 t init

Example 2: (initcall_debug log)
 calling  init+0x0/0x12 @ 1
 initcall init+0x0/0x12 returned 0 after 15 usecs
 calling  init+0x0/0x60 @ 1
 initcall init+0x0/0x60 returned 0 after 2 usecs
 calling  init+0x0/0x9a @ 1
 initcall init+0x0/0x9a returned 0 after 74 usecs
Applied to nf-next, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help