Re: [PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit
From: Florian Westphal <fw@strlen.de>
Date: 2022-03-17 05:34:56
Also in:
linux-block, linux-crypto, linux-rdma, linux-scsi, linux-usb, lkml, netfilter-devel
Randy Dunlap [off-list ref] wrote:
Eliminate anonymous module_init() and module_exit(), which can lead to
confusion or ambiguity when reading System.map, crashes/oops/bugs,
or an initcall_debug log.
Give each of these init and exit functions unique driver-specific
names to eliminate the anonymous names.
Example 1: (System.map)
ffffffff832fc78c t init
ffffffff832fc79e t init
ffffffff832fc8f8 t init
Example 2: (initcall_debug log)
calling init+0x0/0x12 @ 1
initcall init+0x0/0x12 returned 0 after 15 usecs
calling init+0x0/0x60 @ 1
initcall init+0x0/0x60 returned 0 after 2 usecs
calling init+0x0/0x9a @ 1
initcall init+0x0/0x9a returned 0 after 74 usecs
Fixes: f587de0e2feb ("[NETFILTER]: nf_conntrack/nf_nat: add H.323 helper port")
Signed-off-by: Randy Dunlap <redacted>Acked-by: Florian Westphal <fw@strlen.de>