Re: [PATCH 2/9] virtio_console: eliminate anonymous module_init & module_exit
From: Amit Shah <hidden>
Date: 2022-03-17 15:48:22
Also in:
linux-block, linux-crypto, linux-rdma, linux-scsi, linux-usb, lkml, netfilter-devel, nouveau, virtualization
On Wed, 2022-03-16 at 12:20 -0700, Randy Dunlap wrote:
Eliminate anonymous module_init() and module_exit(), which can lead to confusion or ambiguity when reading System.map, crashes/oops/bugs, or an initcall_debug log. Give each of these init and exit functions unique driver-specific names to eliminate the anonymous names. Example 1: (System.map) ffffffff832fc78c t init ffffffff832fc79e t init ffffffff832fc8f8 t init Example 2: (initcall_debug log) calling init+0x0/0x12 @ 1 initcall init+0x0/0x12 returned 0 after 15 usecs calling init+0x0/0x60 @ 1 initcall init+0x0/0x60 returned 0 after 2 usecs calling init+0x0/0x9a @ 1 initcall init+0x0/0x9a returned 0 after 74 usecs Fixes: 31610434bc35 ("Virtio console driver") Fixes: 7177876fea83 ("virtio: console: Add ability to remove module") Signed-off-by: Randy Dunlap < rdunlap@infradead.orgquoted
Cc: Amit Shah < amit@kernel.orgquoted
Cc: virtualization@lists.linux-foundation.org Cc: Arnd Bergmann < arnd@arndb.dequoted
Cc: Greg Kroah-Hartman < gregkh@linuxfoundation.orgquoted
--- drivers/char/virtio_console.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Amit Shah <amit@kernel.org> I don't think the Fixes-by really applies here, though - we don't really want to push this into stable, nor do we want any automated tools to pick this up because of that tag.. Amit