Re: [PATCH] HPE BMC GXP SUPPORT
From: Joe Perches <joe@perches.com>
Date: 2022-02-04 12:18:57
Also in:
dri-devel, linux-devicetree, linux-gpio, linux-i2c, linux-pm, linux-pwm, linux-serial, linux-spi, linux-usb, linux-watchdog, lkml
Possibly related (same subject, not in this thread)
- 2022-02-04 · Re: [PATCH] HPE BMC GXP SUPPORT · Krzysztof Kozlowski <hidden>
- 2022-02-03 · Re: [PATCH] HPE BMC GXP SUPPORT · "Verdun, Jean-Marie" <verdun@hpe.com>
- 2022-02-03 · Re: [PATCH] HPE BMC GXP SUPPORT · Krzysztof Kozlowski <hidden>
On Fri, 2022-02-04 at 12:05 +0000, Russell King (Oracle) wrote:
On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawkins@hpe.com wrote:
[]
quoted
diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile
[]
quoted
+static irqreturn_t gxp_time_interrupt(int irq, void *dev_id) +{ + struct gxp_timer *timer = dev_id; + void (*event_handler)(struct clock_event_device *timer); + +One too many blank lines.quoted
+ if (readb_relaxed(timer->control) & MASK_TCS_TC) { + writeb_relaxed(MASK_TCS_TC, timer->control); + + event_handler = READ_ONCE(timer->evt.event_handler); + if (event_handler) + event_handler(&timer->evt); + return IRQ_HANDLED; + } else { + return IRQ_NONE; + } +}
It's also less indented code and perhaps clearer to reverse the test if (!readb_relaxed(timer->control) & MASK_TCS_TC) return IRQ_NONE; writeb_relaxed(MASK_TCS_TC, timer->control); event_handler = READ_ONCE(timer->evt.event_handler); if (event_handler) event_handler(&timer->evt); return IRQ_HANDLED;