Re: [PATCH] HPE BMC GXP SUPPORT

On 03/02/2022 15:29, Rob Herring wrote:

On Wed, Feb 2, 2022 at 10:55 AM [off-list ref] wrote:

quoted

From: Nick Hawkins <nick.hawkins@hpe.com>

(...)

quoted

+
+       vuart_a: vuart_a@80fd0200 {

serial@...

Maybe it does not look like, but this is actually a v2. Nick was asked
to change the naming for the nodes already in v1. Unfortunately it did
not happen, so we have vuart, spifi, vic and more.

It is a waste of reviewers' time to ask them to perform the same review
twice or to ignore their comments.

quoted

+               compatible = "hpe,gxp-vuart";
+               reg = <0x80fd0200 0x100>;
+               interrupts = <2>;
+               interrupt-parent = <&vic1>;
+               clock-frequency = <1846153>;
+               reg-shift = <0>;
+               status = "okay";
+               serial-line = <3>;
+               vuart_cfg = <&vuart_a_cfg>;
+       };

(...)

quoted

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 294093d45a23..913f722a6b8d 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml

@@ -514,7 +514,9 @@ patternProperties:
   "^hoperun,.*":
     description: Jiangsu HopeRun Software Co., Ltd.
   "^hp,.*":
-    description: Hewlett Packard
+    description: Hewlett Packard Inc.

Why are you changing this one?

I guess this is squashing of my patch:
https://lore.kernel.org/all/20220127075229.10299-1-krzysztof.kozlowski@canonical.com/ (local)

which is fine to me, but vendor changve should be a separate commit with
its own explanation. Now it looks indeed weird.

quoted

+  "^hpe,.*":

You used HPE elsewhere... Lowercase is preferred.

Best regards,
Krzysztof