Re: [PATCH net-next v4 07/11] net: dsa: realtek: rtl8365mb: rename extport to extint, add "realtek,ext-int"
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2022-01-17 04:25:33
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2022-01-17 04:25:33
On 1/4/2022 7:15 PM, Luiz Angelo Daros de Luca wrote:
"extport" 0, 1, 2 was used to reference external ports (ext0, ext1, ext2). Meanwhile, port 0..9 is used as switch ports, including external ports. "extport" was renamed to extint to make it clear it does not mean the port number but the external interface number. The macros that map extint numbers to registers addresses now use inline ifs instead of binary arithmetic. "extint" was hardcoded to 1. However, some chips have multiple external interfaces. It's not right to assume the CPU port uses extint 1 nor that all extint are CPU ports. Now the association between the port and the external interface can be defined with a device-tree port property "realtek,ext-int". This patch still does not allow multiple CPU ports nor extint as a non CPU port. Signed-off-by: Luiz Angelo Daros de Luca <redacted> Tested-by: Arınç ÜNAL <redacted>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian