Re: [PATCH net-next v4 03/11] net: dsa: realtek: remove direct calls to realtek-smi
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2022-01-17 03:48:38
On 1/4/2022 7:15 PM, Luiz Angelo Daros de Luca wrote:
Remove the only two direct calls from subdrivers to realtek-smi. Now they are called from realtek_priv. Subdrivers can now be linked independently from realtek-smi. Signed-off-by: Luiz Angelo Daros de Luca <redacted> ---
[snip] Just a nit below.
quoted hunk ↗ jump to hunk
return 0;@@ -1705,7 +1707,7 @@ static int rtl8366rb_reset_chip(struct realtek_priv *priv) u32 val; int ret; - realtek_smi_write_reg_noack(priv, RTL8366RB_RESET_CTRL_REG, + priv->write_reg_noack(priv, RTL8366RB_RESET_CTRL_REG, RTL8366RB_CHIP_CTRL_RESET_HW);
Only if you need to spin a new version, the second line should start at the character after the opening parenthesis on the previous line. Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian