Re: [PATCH net-next v4 08/11] net: dsa: realtek: rtl8365mb: use GENMASK(n-1,0) instead of BIT(n)-1
From: Alvin Šipraga <ALSI@bang-olufsen.dk>
Date: 2022-01-10 13:18:38
Luiz Angelo Daros de Luca [off-list ref] writes:
Signed-off-by: Luiz Angelo Daros de Luca <redacted> Tested-by: Arınç ÜNAL <redacted> Reviewed-by: Linus Walleij <redacted>
Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
quoted hunk ↗ jump to hunk
--- drivers/net/dsa/realtek/rtl8365mb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c index e115129cd5cd..b22f50a9d1ef 100644 --- a/drivers/net/dsa/realtek/rtl8365mb.c +++ b/drivers/net/dsa/realtek/rtl8365mb.c@@ -1973,7 +1973,7 @@ static int rtl8365mb_detect(struct realtek_priv *priv) mb->priv = priv; mb->chip_id = chip_id; mb->chip_ver = chip_ver; - mb->port_mask = BIT(priv->num_ports) - 1; + mb->port_mask = GENMASK(priv->num_ports - 1, 0); mb->learn_limit_max = RTL8365MB_LEARN_LIMIT_MAX_8365MB_VC; mb->jam_table = rtl8365mb_init_jam_8365mb_vc; mb->jam_size = ARRAY_SIZE(rtl8365mb_init_jam_8365mb_vc);