On Wed, Jan 5, 2022 at 9:33 AM Jakub Kicinski [off-list ref] wrote:

On Tue, 4 Jan 2022 22:12:35 -0800 Dimitris Michailidis wrote:

quoted

On Tue, Jan 4, 2022 at 8:49 PM Dimitris Michailidis

quoted

On Tue, Jan 4, 2022 at 6:10 PM Jakub Kicinski [off-list ref] wrote:

quoted

CHECK: Unnecessary parentheses around 'fdev->admin_q->rq_depth > 0'
#630: FILE: drivers/net/ethernet/fungible/funcore/fun_dev.c:584:
+       if (cq_count < 2 || sq_count < 2 + (fdev->admin_q->rq_depth > 0))

I saw this one but checkpatch misunderstands this expression.
There are different equivalent expressions that wouldn't have them
but this one needs them.

What I wrote is probably unclear. By 'them' I meant the parentheses.

I see, perhaps it's better written as:

        if (cq_count < 2 || sq_count < 2 + !!fdev->admin_q->rq_depth)

That's the "different equivalent expression" I alluded to. I won't
call it better
but I'll appease checkpatch.