On Tue, Jan 4, 2022 at 6:10 PM Jakub Kicinski [off-list ref] wrote:

On Mon,  3 Jan 2022 22:46:51 -0800 Dimitris Michailidis wrote:

quoted

Fungible cards have a number of different PCI functions and thus
different drivers, all of which use a common method to initialize and
interact with the device. This commit adds a library module that
collects these common mechanisms. They mainly deal with device
initialization, setting up and destroying queues, and operating an admin
queue. A subset of the FW interface is also included here.

Signed-off-by: Dimitris Michailidis <dmichail@fungible.com>

CHECK: Unnecessary parentheses around 'fdev->admin_q->rq_depth > 0'
#630: FILE: drivers/net/ethernet/fungible/funcore/fun_dev.c:584:
+       if (cq_count < 2 || sq_count < 2 + (fdev->admin_q->rq_depth > 0))

I saw this one but checkpatch misunderstands this expression.
There are different equivalent expressions that wouldn't have them
but this one needs them.