Re: [PATCH net-next v4 2/8] net/fungible: Add service module for Fungible drivers
From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-01-05 02:10:05
From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-01-05 02:10:05
On Mon, 3 Jan 2022 22:46:51 -0800 Dimitris Michailidis wrote:
Fungible cards have a number of different PCI functions and thus different drivers, all of which use a common method to initialize and interact with the device. This commit adds a library module that collects these common mechanisms. They mainly deal with device initialization, setting up and destroying queues, and operating an admin queue. A subset of the FW interface is also included here. Signed-off-by: Dimitris Michailidis <dmichail@fungible.com>
CHECK: Unnecessary parentheses around 'fdev->admin_q->rq_depth > 0' #630: FILE: drivers/net/ethernet/fungible/funcore/fun_dev.c:584: + if (cq_count < 2 || sq_count < 2 + (fdev->admin_q->rq_depth > 0))