Re: [RFC PATCH v3 4/8] leds: trigger: netdev: rename and expose NETDEV trigger enum modes

On Wed, Nov 10, 2021 at 08:57:24PM +0100, Ansuel Smith wrote:

On Tue, Nov 09, 2021 at 09:58:27PM +0100, Andrew Lunn wrote:

quoted

On Tue, Nov 09, 2021 at 03:26:04AM +0100, Ansuel Smith wrote:

quoted

Rename NETDEV trigger enum modes to a more simbolic name and move them

symbolic. Randy is slipping :-)

quoted

in leds.h to make them accessible by any user.

any user? I would be more specific than that. Other triggers dealing
with netdev states?

Ok will be more specific. A LED driver require to explicitly support the
trigger to run in hardware mode. The LED driver will take the
trigger_data and elaborate his struct to parse all the option
(blink_mode bitmap, interval)

So the user would be a LED driver that adds support for that specific
trigger. That is also the reason we need to export them.

Say i have a SATA controller where i can configure it to blink on
reads, or writes, or both. It also needs to understand these netdev
modes? I was meaning you need to narrow the comment down to a trigger
which has something to do with netdev. I assume other sorts of
hardware offloads will appear in the future, once the generic
infrastructure is there.

	 Andrew