Re: [RFC PATCH v3 3/8] leds: trigger: netdev: drop NETDEV_LED_MODE_LINKUP from mode
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-11-09 20:53:27
Also in:
linux-devicetree, linux-doc, linux-leds, lkml
On Tue, Nov 09, 2021 at 04:02:57AM +0100, Marek Behún wrote:
On Tue, 9 Nov 2021 03:26:03 +0100 Ansuel Smith [off-list ref] wrote:quoted
Drop NETDEV_LED_MODE_LINKUP from mode list and convert to a simple bool that will be true or false based on the carrier link. No functional change intended.The last time I tried this, I did it for all the fields that are now in the bitmap, and I was told that the bitmap guarantees atomic access, so it should be used... But why do you needs this? I guess I will see in another patch.
I agree with Marek here. The commit message says what you have done,
which is not very useful, i can read the patch. What it should include
is why you have made this change. The why is very important in the
commit message.
Andrew