Re: [net-next: PATCH v2 3/7] net/fsl: switch to fwnode_mdiobus_register

czw., 17 cze 2021 o 14:28 Andrew Lunn [off-list ref] napisał(a):

On Thu, Jun 17, 2021 at 01:39:40AM +0200, Marcin Wojtas wrote:

quoted

śr., 16 cze 2021 o 21:35 Andrew Lunn [off-list ref] napisał(a):

quoted

On Wed, Jun 16, 2021 at 09:07:55PM +0200, Marcin Wojtas wrote:

quoted

Utilize the newly added helper routine
for registering the MDIO bus via fwnode_
interface.

You need to add depends on FWNODE_MDIO

Do you mean something like this?

--- a/drivers/net/ethernet/freescale/Kconfig
+++ b/drivers/net/ethernet/freescale/Kconfig

@@ -68,8 +68,8 @@ config FSL_PQ_MDIO
 config FSL_XGMAC_MDIO
        tristate "Freescale XGMAC MDIO"
        select PHYLIB
-       depends on OF
-       select OF_MDIO
+       depends on ACPI || OF
+       select FWNODE_MDIO
        help

You should not need depends on ACPI || OF. FWNODE_MDIO implies
that. And there are no direct calls to of_ functions, so you can drop
the depends on OF.

Ok, I'll leave:
depends on FWNODE_MDIO
only.

Thanks,
Marcin