Re: [net-next: PATCH v2 5/7] net: mvmdio: add ACPI support

On Thu, Jun 17, 2021 at 12:37:06AM +0200, Marcin Wojtas wrote:

śr., 16 cze 2021 o 21:51 Andrew Lunn [off-list ref] napisał(a):

quoted

On Wed, Jun 16, 2021 at 09:07:57PM +0200, Marcin Wojtas wrote:

quoted

This patch introducing ACPI support for the mvmdio driver by adding
acpi_match_table with two entries:

* "MRVL0100" for the SMI operation
* "MRVL0101" for the XSMI mode

Also clk enabling is skipped, because the tables do not contain
such data and clock maintenance relies on the firmware.

This last part seems to be no longer true.

Well, it is still relies on firmware (no clocks are passed via ACPI),
but skipping this enablement is hidden in the internals of
devm_clk_bulk_get_optional() and clk_bulk_prepare_enable().

A quick grep in driver/clk does not reveal any ACPI code. Nor did i
spot any generic clock code in drivers/acpi. So even if you did add
clocks to the tables, i don't see how they would be used.

       Andrew