Re: [PATCH net 2/7] Revert "ibmvnic: remove duplicate napi_schedule call in open function"

On 2021-06-24 10:05, Lijun Pan wrote:

On Thu, Jun 24, 2021 at 2:29 AM Rick Lindsley
[off-list ref] wrote:

quoted

On 6/24/21 12:02 AM, Johaan Smith wrote:

quoted

On Wed, Jun 23, 2021 at 11:17 PM Sukadev Bhattiprolu

quoted

Sometimes git bisect may lead us to the false positives. Full investigation is
always the best solution if it is not too hard.

I'd be happy to view evidence that points at another patch, if someone 
has some.
But the original patch did not address any observed problem:

      "So there is no need for do_reset to call napi_schedule again
       at the end of the function though napi_schedule will neglect
       the request if napi is already scheduled."

Given that it fixed no problem but appears to have introduced one, the 
efficient
action is to revert it for now.

With this reverted patch, there are lots of errors after bringing
device down then up, e.g.,
"ibmvnic 30000003 env3: rx buffer returned with rc 6".
That seems something wrong with the handling of set_link_state
DOWN/UP. It is either the communication protocol or the VIOS itself.

Did the driver bring the link back up with the patch is reverted? When 
link is down, vnic server returns rx buffers back to the client. This 
error message is printed when debug is turned on, driver's way to log 
what happened.