Thread (21 messages) 21 messages, 6 authors, 2021-06-24

Re: [PATCH net 2/7] Revert "ibmvnic: remove duplicate napi_schedule call in open function"

flat view

From: Rick Lindsley <hidden>
Date: 2021-06-24 07:28:40

On 6/24/21 12:02 AM, Johaan Smith wrote:
On Wed, Jun 23, 2021 at 11:17 PM Sukadev Bhattiprolu
Sometimes git bisect may lead us to the false positives. Full investigation is
always the best solution if it is not too hard.
I'd be happy to view evidence that points at another patch, if someone has some.
But the original patch did not address any observed problem:

     "So there is no need for do_reset to call napi_schedule again
      at the end of the function though napi_schedule will neglect
      the request if napi is already scheduled."

Given that it fixed no problem but appears to have introduced one, the efficient
action is to revert it for now.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help