Re: [PATCH net 2/7] Revert "ibmvnic: remove duplicate napi_schedule call in open function"
From: Lijun Pan <hidden>
Date: 2021-06-24 06:20:59
On Wed, Jun 23, 2021 at 11:16 PM Sukadev Bhattiprolu [off-list ref] wrote:
From: Dany Madden <redacted> This reverts commit 7c451f3ef676c805a4b77a743a01a5c21a250a73. When a vnic interface is taken down and then up, connectivity is not restored. We bisected it to this commit. Reverting this commit until we can fully investigate the issue/benefit of the change.
The reverted patch shouldn't be the real cause of the problem. It is very likely VIOS does not forward the rx packets so that the rx interrupt isn't raised.
quoted hunk ↗ jump to hunk
Fixes: 7c451f3ef676 ("ibmvnic: remove duplicate napi_schedule call in open function") Reported-by: Cristobal Forno <redacted> Reported-by: Abdul Haleem <redacted> Signed-off-by: Dany Madden <redacted> Signed-off-by: Sukadev Bhattiprolu <redacted> --- drivers/net/ethernet/ibm/ibmvnic.c | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index f13ad6bc67cd..fe1627ea9762 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c@@ -1234,6 +1234,11 @@ static int __ibmvnic_open(struct net_device *netdev) netif_tx_start_all_queues(netdev); + if (prev_state == VNIC_CLOSED) { + for (i = 0; i < adapter->req_rx_queues; i++) + napi_schedule(&adapter->napi[i]); + } +
interrupt_rx will schedule the napi, so not necessary here.